Added Shoud-HaveParameter Assertion#1202
Merged
nohwnd merged 11 commits intopester:masterfrom Jan 21, 2019
Merged
Conversation
added assertion to test the parameters of a cmdlet
argument needs `= $true` value. only PSv3+ imply `[Parameter(Mandatory)]` to be the same as [Parameter(Mandatory = $true)]
3d5ca43 to
4b0e1ce
Compare
4b0e1ce to
1bfa2f0
Compare
Added ValidateScript to the test function to ensure Tokenize can handle the groups properly
Fixed error message on psv2: > ``` > RuntimeException: Method invocation failed because [System.Management.Automation.PSToken] doesn't contain a method named 'get_Item'. > ```
Contributor
Author
|
All green! remind me not to contribute to modules that support psv2 😠 |
Member
|
@lipkau I changed your api a bit, and fixed the names in the tests to be more descriptive. ok? |
Contributor
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. General summary of the pull request
added assertion to test the parameters of a cmdlet