Skip to content

Fix formatting to use automatic Struostrup style in VSCode#1203

Merged
nohwnd merged 2 commits intomasterfrom
formatting
Jan 9, 2019
Merged

Fix formatting to use automatic Struostrup style in VSCode#1203
nohwnd merged 2 commits intomasterfrom
formatting

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Jan 9, 2019

Formatted all the files, and fixed tests that depend on formatting

  • Checking that 2 calls to Add-AssertonOperator are the same (added whitespace made the scripts different)
  • Checking fail position in file, adding whitespace moved the $script we use for check in a different line, so I've put it before the assertion with ; so it stays on the same line.

Fix #1110

@fourpastmidnight
Copy link
Copy Markdown
Contributor

Is this the same as OTBS that the PowerShell community seems to have adopted?

@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Jan 9, 2019

IDK what is the exact difference, but this one puts else on new line. And Pester is mentioned in the powershell style guide entry for this dtyle, so I figured why not.

@nohwnd nohwnd merged commit b7904b0 into master Jan 9, 2019
@nohwnd nohwnd deleted the formatting branch January 11, 2019 20:48
@jkavanagh58
Copy link
Copy Markdown

Okay I can leverage these as ISE snippets just fine since they are XML so why the worry regarding VSCode OTBS?

@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Apr 19, 2019

@jkavanagh58 I don't get what you mean. Could you please re-phrase/expand on it?:)

@jkavanagh58
Copy link
Copy Markdown

@jkavanagh58 I don't get what you mean. Could you please re-phrase/expand on it?:)

Sadly I don't remember now...

@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented May 24, 2019

@jkavanagh58 we are not finding out then :D

@jkavanagh58
Copy link
Copy Markdown

Admittedly I am struggling to test this but I have some time on my hands so I will see if I can illustrate this better or maybe see where I need to "find target on wall, aim forehead and whack" 🔢
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Formatting - Style Guide/Settings for VSCode

3 participants