Allow mocks to work with conflicting parameter names#1233
Merged
nohwnd merged 5 commits intopester:masterfrom Feb 3, 2019
Merged
Allow mocks to work with conflicting parameter names#1233nohwnd merged 5 commits intopester:masterfrom
nohwnd merged 5 commits intopester:masterfrom
Conversation
renehernandez
force-pushed
the
rename-conflicting-params-names
branch
from
04f15f5 to
fb30102
Compare
Contributor
Author
|
@nohwnd the powershell 2 run failed before running the tests and it is not clear to why or where exactly. Any inputs? |
nohwnd
requested changes
Feb 2, 2019
Member
|
@renehernandez Thanks for your PR. 🙂 You have to use |
added 3 commits
February 3, 2019 12:17
Remove prefix function Replace pipeline usage by foreach Use null assignment instead of out-null R
Capture Remove method call in $null var
nohwnd
approved these changes
Feb 3, 2019
Member
|
Merged! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. General summary of the pull request
Fix #1007
Allow Mock to overcome names in parameters that shouldn't be used by prefixing them with the _ identifier.