Allow aliases in Parameter Filters blocks

[renehernandez]

1. General summary of the pull request

Fix #1128

[renehernandez]

@nohwnd 21 tests failed in the powershell 3 job. They are related to Gherkin, which are not related to these changes. I looked in the job history and those Gherkin tests failed in the job associated to the previous pull request as well.

[renehernandez]

The powershell 2 job is apparently stuck waiting for an agent to run, but these changes shouldn't be validated against powershell 2 anyways. Any inputs?

[renehernandez]

Ok I realized now that the pull request should be targeted against v5 branch instead of master. Will close and open a new pull request

[renehernandez]

Ok I realized now that the pull request should be targeted against v5 branch instead of master. Will close and open a new pull request

@nohwnd Actually I am not sure how to proceed here. I checked the latest status of mocking in v5 and it doesn't have yet the previous mocking fixes that I have implemented

[nohwnd]

@renehernandez This should target the master, not v5. The agent running powershell v2 is stuck for some reason, I just restarted the VM so hopefully it will come back and start building. Otherwise I need to investigate. The tests & code that is PowerShell 3+ specific should go into an if that will use the GetPesterPSVersion function (it's called something like that). So it can still work like before on v2. If tests started failing in Gherkin then there is probably some behaviour that has changed by your changes, and it needs to be investigated an addressed. I should be able to help with that later.

[nohwnd]

Okay restart did not help, but I solve it. The problem is that VSTS agent is not compatible with PowerShell 2 so what I am doing is patching the app via compatibility shimming to think it runs on v3 and then giving it PowerShell 6 instead, so it is all just a big hack. The problem was that I specified a version of the Agent.Listener executable in the shim and the agent updated and so it started seeing the real powershell version and refused to start up.

[renehernandez]

If tests started failing in Gherkin then there is probably some behaviour that has changed by your changes, and it needs to be investigated an addressed. I should be able to help with that later.

@nohwnd The gherkins testst were already failing in the previous build job before mine, as can be checked here. I have also looked at the stacktrace of the error by they don't seem to be hitting anything related to my mocking changes

[renehernandez]

@nohwnd Now only the PowerShell 3 job is failing in the Gherkins tests

[nohwnd]

@renehernandez okay will have a look, that error looks weirdly unrelated. I can also see that the master started failing, so maybe it's not a problem of this PR at all.

[renehernandez]

@nohwnd Any update on the Gherkin issues?? How can I help with that?

[nohwnd]

I looked at the failed builds and frankly I have no idea why they started failing. I need to have a closer look on it, hopefully I’ll be able to do that today.

[renehernandez]

@nohwnd I guess I should have looked into the exceptions sooner. I had ran into that issue before and I found a solution at this uservoice thread

The problem seems to be that older version of powershell weren't capable of properly managing different encodings with BOM between the current process and a triggered background job

[nohwnd]

@renehernandez aaah, that's why there is apparently no change, especially no change in the xmls.

[nohwnd]

@renehernandez merged, thanks!