Skip to content

Fix incorrect Code Coverage report counters (#1242)#1244

Merged
nohwnd merged 3 commits intopester:masterfrom
tbravo5:master
Feb 26, 2019
Merged

Fix incorrect Code Coverage report counters (#1242)#1244
nohwnd merged 3 commits intopester:masterfrom
tbravo5:master

Conversation

@tbravo5
Copy link
Copy Markdown
Contributor

@tbravo5 tbravo5 commented Feb 14, 2019

1. General summary of the pull request

Fix #1242

Fixes incorrect Code Coverage report counters when there are multiple packages in the report.

@tbravo5
Copy link
Copy Markdown
Contributor Author

tbravo5 commented Feb 14, 2019

@nohwnd I'm not sure how to move ahead here. The builds/tests in the environments I'm familiar with worked but failed in others.

@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Feb 15, 2019

@toddbrownmcis Not sure what the problem is, it looked like a newline issue, but the error also happens on windows on PS Core. You should be able to easily replicate it by installing PowerShell 6 on your windows and run it. It also integrates very well with VSCode, so it should be easy to debug. If you cannot crack it let me know 🙂

@tbravo5
Copy link
Copy Markdown
Contributor Author

tbravo5 commented Feb 15, 2019

@nohwnd Updated TestScript3.ps1 subfolder name from SubFolder to TestSubFolder. This seems to have corrected the test issue. I believe the underlying issue is with Group-Object sort order in different environments.

Test script paths before:
$root\TestScript1.ps1
$root\TestScript2.ps1
$root\SubFolder\TestScript3.ps1

Test script paths after:
$root\TestScript1.ps1
$root\TestScript2.ps1
$root\TestSubFolder\TestScript3.ps1

@nohwnd nohwnd merged commit 30c5f7e into pester:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants