Shorten error message of string comparison when it is too long#1248
Shorten error message of string comparison when it is too long#1248nohwnd merged 13 commits intopester:masterfrom
Conversation
|
@jd-porter is this still work in progress? Please add some tests. :) |
|
@jd-porter Are you interested in adding the tests? If not let me know please, so I can finish this :) |
|
Can do. I'll finish them up this weekend and resubmit the PR
…________________________________
From: Jakub Jareš <notifications@github.com>
Sent: Thursday, March 14, 2019 12:21:21 AM
To: pester/Pester
Cc: Porter, Jesse; Mention
Subject: Re: [pester/Pester] WIP: Shorten error message of string comparison when it is too long (#1248)
@jd-porter<https://github.com/jd-porter> Are you interested in adding the tests? If not let me know please, so I can finish this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1248 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANaTezWwWUh1Xsg0lkaLPrObiKkgg3Edks5vWephgaJpZM4a_LHW>.
|
|
Updated be.tests and I think we're good to go! |
|
Merged, thanks! |
|
oh nice! Thank you for the merge! I saw that the merge had a failure in the Powershell 2 tests last night and wasn't quite sure how I could test that on my system at home... Is that test outdated? |
|
Nice 🎉 🌮 🇹🇼 |
|
@jd-porter You could do that if you install a virtual machine put some old system in there, like Windows 7 without SP (I think). But the whole problem with the build was that the PowerShell Jobs that we use to test Pester in Pester are a bit flaky on PS2, so the test run failed. I just re-run it and it passed just fine. |
1. General summary of the pull request
Modify Be.ps1 to show excerpts of string comparisons when actual or expected values are very long.
Fixes #532