Skip to content

Shorten error message of string comparison when it is too long#1248

Merged
nohwnd merged 13 commits intopester:masterfrom
jd-porter:ErrorMessages-532
Mar 16, 2019
Merged

Shorten error message of string comparison when it is too long#1248
nohwnd merged 13 commits intopester:masterfrom
jd-porter:ErrorMessages-532

Conversation

@jd-porter
Copy link
Copy Markdown
Contributor

@jd-porter jd-porter commented Feb 16, 2019

1. General summary of the pull request

Modify Be.ps1 to show excerpts of string comparisons when actual or expected values are very long.

Fixes #532

@nohwnd nohwnd changed the title Error messages 532 Shorten error message of string comparison when it is too long Feb 22, 2019
@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Feb 22, 2019

@jd-porter is this still work in progress? Please add some tests. :)

@nohwnd nohwnd changed the title Shorten error message of string comparison when it is too long WIP: Shorten error message of string comparison when it is too long Feb 22, 2019
@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Mar 14, 2019

@jd-porter Are you interested in adding the tests? If not let me know please, so I can finish this :)

@jd-porter
Copy link
Copy Markdown
Contributor Author

jd-porter commented Mar 15, 2019 via email

@jd-porter
Copy link
Copy Markdown
Contributor Author

Updated be.tests and I think we're good to go!

@nohwnd nohwnd changed the title WIP: Shorten error message of string comparison when it is too long Shorten error message of string comparison when it is too long Mar 16, 2019
@nohwnd nohwnd merged commit f5d5256 into pester:master Mar 16, 2019
@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Mar 16, 2019

Merged, thanks!

@jd-porter
Copy link
Copy Markdown
Contributor Author

oh nice! Thank you for the merge! I saw that the merge had a failure in the Powershell 2 tests last night and wasn't quite sure how I could test that on my system at home... Is that test outdated?

@vors
Copy link
Copy Markdown
Member

vors commented Mar 16, 2019

Nice 🎉 🌮 🇹🇼

@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Mar 17, 2019

@jd-porter You could do that if you install a virtual machine put some old system in there, like Windows 7 without SP (I think). But the whole problem with the build was that the PowerShell Jobs that we use to test Pester in Pester are a bit flaky on PS2, so the test run failed. I just re-run it and it passed just fine.

nohwnd added a commit that referenced this pull request Aug 15, 2020
nohwnd added a commit that referenced this pull request Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants