WIP: Check if function exists before removing it#1255
Merged
nohwnd merged 2 commits intopester:masterfrom Mar 27, 2019
Merged
Conversation
Contributor
Author
|
@nohwnd Any updates on this? I am looking forward to getting it merge in :) |
Member
|
@renehernandez I think I marked it as WIP because I saw that it's failing, and then did not check it again (which is why I add WIP to it, so I don't end up looking 20 times at the same PR trying to figure out what is the status). If you fix something next time please look if I did not mark it wip in the meantime, and ping me, it will get merged much faster :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. General summary of the pull request
Fix #952