Add support for logging the reason if a test is skipped or marked pending#1353
Merged
nohwnd merged 1 commit intopester:masterfrom Aug 28, 2019
Merged
Add support for logging the reason if a test is skipped or marked pending#1353nohwnd merged 1 commit intopester:masterfrom
nohwnd merged 1 commit intopester:masterfrom
Conversation
…ending. The schema seems to allow this.
JamesWTruher
force-pushed
the
MessageForSkipPend
branch
from
1d97467 to
96dd9e0
Compare
Contributor
Author
|
@nohwnd - if you have time would you take a look? |
Member
|
Merged thanks. Will try to do release till the end of the week. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you create a nunit log, the reason for skipping or a pending test is not persisted, but the schema seems to allow this, and we would like to keep the information in our logs.
1. General summary of the pull request
The nunit schema allows for a reason to be associated with a test which is skipped or marked pending (or inconclusive). While the current behavior provides a way to emit a reason for skipping or pending, that is only written to the console and not persisted. This PR ensures that those reasons (if provided) will make it into the nunit log.