Fix #2657 and #2649: Clear-TestDrive performance and NUnit3 ToString crash#2688
Closed
nohwnd wants to merge 1 commit intopester:mainfrom
Closed
Fix #2657 and #2649: Clear-TestDrive performance and NUnit3 ToString crash#2688nohwnd wants to merge 1 commit intopester:mainfrom
nohwnd wants to merge 1 commit intopester:mainfrom
Conversation
…t3 ToString crash pester#2657: Clear-TestDrive was extremely slow with many files because it called Remove-Item on every individual file. Replaced with HashSet-based approach that only calls Remove-Item -Recurse on root new items. pester#2649: NUnit3 report writing crashed when a test output objects ToString() throws. Wrapped in try/catch with a descriptive fallback string. Copilot-generated fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
both look okay, not sure why you put it in the same PR, split to two. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pester 6 Fixes (Copilot-generated)
Fix #2657: Clear-TestDrive performance
Clear-TestDrive was extremely slow with many files because it called
Remove-Itemon every individual file. Replaced with HashSet-based approach that only callsRemove-Item -Recurseon root new items.Fix #2649: NUnit3 ToString crash protection
NUnit3 report writing crashed when a test output object's
ToString()method throws. Wrapped in try/catch with a descriptive fallback string.All 2154 tests pass locally.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com