Fix #2701: Should -BeOfType resolves PowerShell classes from actual value#2729
Merged
Conversation
When the expected type is passed as a string and -as [Type] fails (common with PowerShell classes loaded via dot-sourcing in BeforeAll), fall back to walking the actual value's type hierarchy and comparing type names. This lets 'Should -BeOfType testInstance' work even when the class isn't visible to the module's session state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tests the fallback path that resolves types from the actual value's inheritance chain when -as [Type] fails. Includes an integration test with a PowerShell class not visible to the module scope. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The nested Invoke-Pester corrupted module state causing the next test file (BeTrueOrFalse.Tests.ps1) to fail in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2701
PowerShell classes loaded via dot-sourcing in
BeforeAllare not visible to the Pester module's session state, so-as [Type]fails when the expected type is passed as a string (e.g.Should -BeOfType testInstance).When the string-to-type resolution fails, we now walk the actual value's type hierarchy comparing
NameandFullName. This lets the assertion pass when the object genuinely is of the expected type, even if the type isn't globally resolvable.Still throws
ArgumentExceptionif neither-as [Type]nor the fallback finds a match (e.g. actual is\$nullor genuinely wrong type).