Update Gherkin for Pester 4 Changes#715
Merged
dlwyatt merged 16 commits intopester:DevelopmentV4from Mar 2, 2017
Merged
Conversation
Removed "BeforeAllFeatures" and "AfterAllFeatures" hooks that didn't actually work right Updated tests to match
Also Removes some hooks.
This way, Pester's default output shows the "Could not find" message!
I cannot explain why, but it fixes a generics type reference in PowerShell 2
Contributor
Author
|
@nohwnd can you explain what this failure is? Did I actually break PowerShell 2, or is the TeamCity script broken? It's claiming there's a syntax error with an = missing, but that means nothing to me. If I actually broke the build on PS2, I can find a VM to test on and fix it, but ... |
Put the .feature location into the "stack" on failures. Refactor Import-GherkinFeature to add the path to the location Add and fix tests showing that the gherkin scope works as expected
Member
|
@Jaykul sorry I missed your comment, will have a look soon. |
Member
Contributor
Author
|
I'll fix these then. |
Jaykul
changed the title
Jaykul
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fail -- right now.
Once it's fixed, it will fix #714 and then you can merge it.