[3.x] Allow container bindings for http classes (laravel arch preset)#1332
Closed
ol1s wants to merge 1 commit intopestphp:3.xfrom
ol1s:allow-container-bindings-for-http
Closed
[3.x] Allow container bindings for http classes (laravel arch preset)#1332ol1s wants to merge 1 commit intopestphp:3.xfrom ol1s:allow-container-bindings-for-http
ol1s wants to merge 1 commit intopestphp:3.xfrom
ol1s:allow-container-bindings-for-http
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Current Laravel arch preset only allows
App\Httpclasses to be used withinApp\Http.This makes sense MOST of the time.
But feels reasonable to accept that container bindings for controllers/middleware MAY be manually registered in service providers eg. primitives https://laravel.com/docs/11.x/container#binding-primitives
This means
App\Httpalso needs to be usable inApp\Providers.