Skip to content

Gold infopanel update fix#1

Closed
jimfcarroll wants to merge 3 commits intopetchema:gold-infopanel-updatefrom
jimfcarroll:gold-infopanel-update-fix
Closed

Gold infopanel update fix#1
jimfcarroll wants to merge 3 commits intopetchema:gold-infopanel-updatefrom
jimfcarroll:gold-infopanel-update-fix

Conversation

@jimfcarroll
Copy link
Copy Markdown

@jimfcarroll jimfcarroll commented Sep 15, 2019

This sets the value of a gold piece, in gold pieces, to 1, which fixes the value display in the info panel and generally seems more correct than having it as zero. However, I'm not sure what other side-effect this might have.

TheLacus and others added 3 commits September 15, 2019 13:45
Doesn't work well right now because gold stack has 0 value (because its
parent.value is also 0). I'm not sure how to best fiix this :(
@petchema
Copy link
Copy Markdown
Owner

It seems mixed with other changes, so I didn't merge the whole PR, but thanks!
So I kept 858b565 now as you said it needs testing...

@petchema petchema closed this Sep 15, 2019
@jimfcarroll
Copy link
Copy Markdown
Author

Strange. I based it off your branch. It's a 1 line change. In any case it fixes another issue. When you're in the dialog where you can pick up gold, it now sets that value correctly also. Previously it was 0 there also.

@jimfcarroll
Copy link
Copy Markdown
Author

Heh, actually, you're right. I took Interkarma's master and cherry picked your commits. Anyway, I hope it helps.

@petchema
Copy link
Copy Markdown
Owner

petchema commented Sep 15, 2019

Looks good!
I don't think there's a huge probability of breaking something, but I've been known to be wrong sometimes ;) Just trying to be careful now that DFU is in alpha...

Mmmh maybe it's just GitHub playing tricks when displaying diffs then.
Meh, I tried to merge your branch locally and to force-push it over my online edit, and now the commit has an imaginary commiter, what a mess.

I'm currently more focused on improving keyboard support
Interkarma#1510
so if you want to submit it as a PR directly upstream, go ahead :)

@jimfcarroll jimfcarroll deleted the gold-infopanel-update-fix branch September 15, 2019 16:08
petchema pushed a commit that referenced this pull request Sep 14, 2020
Basic bulletin board setup
petchema pushed a commit that referenced this pull request Sep 14, 2020
Added support for Breaking and Entering as a crime
petchema pushed a commit that referenced this pull request Dec 24, 2020
petchema pushed a commit that referenced this pull request Feb 2, 2021
petchema pushed a commit that referenced this pull request Mar 28, 2024
RMB Block Editor: Adds a catalog system to the RMB block editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants