Conversation
Owner
|
lgtm, merge away |
derek-so
added a commit
that referenced
this pull request
Apr 24, 2019
…eta data) stf test (p4lang#1857) * emit psa_packet_paths (#13) * basic stf test for psa recirculate * Added more complexity to psa-recirculate tests, tests 3 different packets being recirculated simultaneously * a more logical test to test recirc * add ignore test
peteli3
pushed a commit
that referenced
this pull request
Jun 6, 2019
…eta data) stf test (p4lang#1857) * emit psa_packet_paths (#13) * basic stf test for psa recirculate * Added more complexity to psa-recirculate tests, tests 3 different packets being recirculated simultaneously * a more logical test to test recirc * add ignore test
kevinye2
pushed a commit
that referenced
this pull request
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we said we aren't merging to ours, please leave a comment if you think its ok. Its just a copy and paste from simple switch, it will let us use the packet path values in bmv2. This is also blocking our bmv2 PR.