Fix review findings before production promotion#181
Merged
peterdrier merged 3 commits intomainfrom Apr 8, 2026
Merged
Conversation
…handling, docs - Reset GoogleEmailStatus to Unknown in FixEmailRenameAsync so sync resumes after admin fixes a renamed email (nobodies-collective#459) - Scope deletion event holds to active event tickets via TicketSyncState VendorEventId, moved logic from GuestController to ProfileService - Align FinanceController projection display with MaterializeProjections engine by using GetProjectionsAsync instead of manual calculation - Save per-user atomically in ProcessAccountDeletionsJob to prevent partial anonymization on failure (GDPR compliance) - Add try-catch + logging to TicketingBudgetService and pass CancellationToken through to SaveChangesAsync - Add error handling to 6 CampAdminController actions - Fix stale doc references: /Admin/SyncSettings → /Google/SyncSettings, /Admin/GroupSettingsResults → /Google/GroupSettingsResults, remove outdated "CURRENTLY DISABLED" notes - Fix "Back to Member Detail" → "Back to Human Detail" Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…e key crash AddUserToGroupAsync: inspect the 403 error message to distinguish service-account permission errors (caller lacks group access) from member-level rejection (no Google account). Only mark GoogleEmailStatus as Rejected for the latter — permission errors are logged but don't permanently exclude the user from sync. ProfileService.GetFilteredHumansAsync: the notification email lookup used ToDictionaryAsync which crashes on duplicate keys if a user has multiple verified notification-target emails. Changed to GroupBy + First to safely handle duplicates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Refunded/cancelled/void tickets for the current event no longer delay GDPR deletion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The preview deployment for humans-qa failed. 🔴 Open Build Logs | Open Application Logs Last updated at: 2026-04-08 14:06:55 CET |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Findings from code review of origin/main vs upstream/main before production promotion. Includes both Claude review and Codex adversarial review findings.
Test plan
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com