City planning: geojson properties documentation, fixes on UX for history

[davinov]

• Document the expected properties in the geojson files to upload
• Multiple fixes for the history panel
  • history button is accessible when clicking on a barrio, in the popup (like the edit button)
  • everyone can access it and preview it, but only editors can restore versions
  • previewed zones are validated (check with the other barrios and the limit zones), but avoid conflict with their current version
• Move the admin button to the top right to avoid colliding with the rest of the action bar at the bottom

[peterdrier]

Code Review

Overall: Looks good — well-structured improvements to history panel UX, proper event listener attachment, and good localization coverage. A few items worth discussing below.

Potential Issue: Hardcoded English strings in JavaScript

• edit.js: The history panel title is set to History of ${campName} (hardcoded English). Since the rest of the page is localized via @Localizer[...], this stands out. The panel's default title from the partial (_HistoryOffcanvas.cshtml) uses @Localizer["CityPlanning_HistoryTitle"], but the JS override doesn't go through localization. Consider passing the localized format string via a data-* attribute on the panel element or via the CONFIG object, e.g. data-history-title-template with a {0} placeholder.
• Similarly, strings like "No history yet.", "Preview", "Restore", and "Restore this version?" in edit.js are hardcoded English. These are pre-existing, but since this PR touches the history feature, it may be a good time to extract them.

Authorization: canEdit vs IS_MAP_ADMIN for Restore

• edit.js (line ~201/237): The Restore button visibility changed from CONFIG.IS_MAP_ADMIN to the canEdit parameter. This is a deliberate design change (camp leads who can edit their own polygon can also restore their own history) and the description confirms this intent. The server-side CanUserEditAsync check on the restore endpoint protects against unauthorized use, so this is safe. Good change.

Defensive coding improvement

• edit.js clearDrawLabel(): Adding optional chaining (?.) to map.getSource(...) calls is a good defensive improvement. This prevents crashes if sources haven't been added yet (e.g., during initialization or if limit zone data is absent).

Minor: Nested wrapper divs in admin link

• Index.cshtml (new admin panel link): The markup has three levels of nesting (position-absolute > card > card-body > d-flex > d-flex) for a single button. This could be simplified to fewer wrapper divs, though it works fine as-is.

Note: GeoJSON property rename (sound_zone -> SoundZone)

• layers.js: This PR renames the GeoJSON property from sound_zone to SoundZone. If any limit zone GeoJSON files have already been uploaded to the database with sound_zone as the property name, those will stop rendering colored sound zone borders. This is a breaking change for existing data. Either existing data needs to be re-uploaded, or the code should support both property names during a transition period (e.g., f.properties?.SoundZone || f.properties?.sound_zone).

Suggestions

• The loadHistory function doesn't check resp.ok before calling resp.json(). If the API returns an error status, this will throw. Consider adding a guard: if (!resp.ok) { list.innerHTML = '<p class="text-danger">Failed to load history.</p>'; return; }. (This is a pre-existing pattern, not introduced by this PR.)
• The previewCampSeasonId state management is clean — setting it on preview click and clearing it on offcanvas close with { once: true } is well done.

Thanks for the contribution! 🎉

[peterdrier]

-- Peter here, don't worry about the localization yet, I haven't figured out a good way to do that in JS yet (unless you know one?) The rest are more informational.. I can wrap this up later when I get to merging..