Add "Set column width to maximum/minimum" actions#148
Add "Set column width to maximum/minimum" actions#148peterfajdiga merged 1 commit intopeterfajdiga:masterfrom
Conversation
peterfajdiga
left a comment
peterfajdiga
left a comment
There was a problem hiding this comment.
This is a nice feature, thanks!
column.minWidth() can be too small to be useful. That's why I'm thinking if maybe instead of using column.minWidth() and column.maxWidth, we should use min(config.presetWidths) and max(config.presetWidths). Help me decide. What do you think?
|
Yes, |
peterfajdiga
left a comment
peterfajdiga
left a comment
There was a problem hiding this comment.
Nice! But I think the previous descriptions and variable and function names were better. They were more concise, yet descriptive enough, in my opinion.
The width is set to the maximum/minimum of preset widths. work
jinliu
force-pushed
the
feature/column-width-max
branch
from
96db9f1 to
d0e07b1
Compare
|
I haven't noticed this last commit until now. Thank you, this looks great now! Btw, the force push caused the commit history to be lost and Github didn't show me the diff between the last commit that I've reviewed and this latest one. Just FYI. |
2 participants
No description provided.