-
Notifications
You must be signed in to change notification settings - Fork 0
Updated pre-commit hooks and requirements, updated python version 3.13 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request upgrades the project to Python 3.13. This is achieved by updating the Python version specified in the CI workflow and pre-commit configurations, refreshing pre-commit hook versions to their latest, and pinning main dependencies. Type hints were also modernized to use the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @petermcd - I've reviewed your changes - here's some feedback:
- Consider if exclusively targeting Python 3.13 in
setup.cfgis intended, as this removes support for versions 3.10-3.12. - Verify the
blacktarget-versioninsetup.cfg(currentlypy113), as it might be a typo forpy313.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
CICD failure is a false positive by SNYK. SNYK is not able to install the package due to not having the prerequisites to install it (the Mariadb connector) |
Updated python to version 3.13
Updated requirements to latest versions and pinned
Updated pre-commit hooks to latest versions
Updated pre-commit workflow to correct name of main branch
Summary by Sourcery
Update project dependencies, Python version, and development tooling to the latest versions
New Features:
Enhancements:
CI:
Chores: