Update docker compose setup for best practices #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes several cosmetic/non-function changes to how docker compose is set up: - Files in the form `docker-compose-xxx.yml` are renamed to `compose-xxx.yaml` to better follow the normal naming practice for compose files. See https://docs.docker.com/compose/compose-application-model/#the-compose-file. Since docker compose V2, the `docker-` prefix is no longer used. - Removes the `version` field from the compose files. This field is obsolete, and its presence was causing a warning to be printed. See https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements
Owner
Author
|
Thanks Albert 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes several cosmetic/non-function changes to how docker compose is set up:
Files in the form
docker-compose-xxx.ymlare renamed tocompose-xxx.yamlto better follow the normal naming practice for compose files. See https://docs.docker.com/compose/compose-application-model/#the-compose-file. Since docker compose V2, thedocker-prefix is no longer used.Removes the
versionfield from the compose files. This field is obsolete, and its presence was causing a warning to be printed. See https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elementsExplicitly sets
tagsas an empty string to remove a warning about it not being set.Check List
Have you:
Added unit tests? N/A
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) N/A
Related Issue