Move cmpgeos workaround skip lists to blacklist.txt#692
Merged
peterstace merged 3 commits intomasterfrom Feb 1, 2026
Merged
Conversation
Remove inline skip lists and workarounds from cmpgeos check functions for cases where GEOS produces incorrect results or crashes. Instead, blacklist these problematic geometries in blacklist.txt so they are excluded from testing entirely.
peterstace
changed the title
Remove containsNonEmptyPointInMultiPoint, containsMultiLineStringWithEmptyLineString, and hasEmptyPoint functions that are no longer used after recent refactoring. Also use errors.New instead of fmt.Errorf where no formatting is needed, and add nolint directive for intentional else-after-return structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove inline skip lists and workarounds from cmpgeos check functions for cases where GEOS produces incorrect results or crashes. Instead, blacklist these problematic geometries in blacklist.txt so they are excluded from testing entirely. Also remove some workarounds that aren't needed for the latest version of GEOS.
Check List
Have you:
Added unit tests? N/A
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) N/A
Updated the README.md (if new functionality is added?) N/A
Related Issue