Skip to content

Conversation

@Flowdalic
Copy link
Contributor

also use b2lx instead of hexlify for python3 support.

@petertodd
Copy link
Owner

re: CTransaction.id(), did you see how the most recent version has a .GetHash() doing that? (similar to the Bitcoin Core codebase)

@jtimon
Copy link

jtimon commented Oct 11, 2014

maybe

            setattr(CTransaction, 'id', getattr(CTransaction, 'GetHash'))

for convenience?

@Flowdalic
Copy link
Contributor Author

re: CTransaction.id(), did you see how the most recent version has a .GetHash() doing that?

Nope. Shall I rebase the branch and remove e2acaca?

@petertodd
Copy link
Owner

@Flowdalic Sure, and give me some feedback on how that syntax/naming works for you.

@Flowdalic
Copy link
Contributor Author

@petertodd rebased and removed the "Add id()" commit.

@petertodd petertodd merged commit 1066519 into petertodd:master Jan 3, 2015
petertodd added a commit that referenced this pull request Jan 3, 2015
1066519 Use b2lx instead of hexlify in net.py (Florian Schmaus)
a93dad4 Add msg_reject (Florian Schmaus)
7c46991 Add msg_notfound (Florian Schmaus)
ghtdak pushed a commit to ghtdak/python-bitcoinlib that referenced this pull request Dec 1, 2015
1066519 Use b2lx instead of hexlify in net.py (Florian Schmaus)
a93dad4 Add msg_reject (Florian Schmaus)
7c46991 Add msg_notfound (Florian Schmaus)

 [ yapified by gitreformat (github/ghtdak) on Mon Nov 30 21:11:42 2015 ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants