implement bip-0037 in version message #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertodd
added a commit
that referenced
this pull request
Dec 23, 2017
b555d4a Add relay to __repr__ (David) 1a0beca implement bip-0037 in version message (David) Pull request description: According to bip-0037 Version messages above 70001 require a Relay Flag By default is true, but you can change to false with setter. https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki Tree-SHA512: 4863ce6456277bcad7fc65ec7dea29da4679c6e2ad5fee0073f2861eb8999b4ce100016570d980bc93c76ce21f64caa79aa4461f864edd8054fb538497cfd11c
Contributor
|
This change breaks Test_msg_version testcase (None can not be serialized into Int on the second serialization). |
rawBit-io
pushed a commit
to rawBit-io/python-bitcointx
that referenced
this pull request
Nov 6, 2025
c1d7d75 Add relay to __repr__ (David) 9ca062e implement bip-0037 in version message (David) Pull request description: According to bip-0037 Version messages above 70001 require a Relay Flag By default is true, but you can change to false with setter. https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki Tree-SHA512: 4863ce6456277bcad7fc65ec7dea29da4679c6e2ad5fee0073f2861eb8999b4ce100016570d980bc93c76ce21f64caa79aa4461f864edd8054fb538497cfd11c
rawBit-io
pushed a commit
to rawBit-io/python-bitcointx
that referenced
this pull request
Nov 6, 2025
rawBit-io
pushed a commit
to rawBit-io/python-bitcointx
that referenced
this pull request
Nov 6, 2025
677e36e - fix for Test_msg_version serialization test (petertodd#160) (Robert Ayrapetyan) Pull request description: Tree-SHA512: bcaac8e6dd47ccbac6c75b3e3b883e427e880a42393be8c766d958c51d935944a6e60efe48a9bfa5ff674da95d616476a1624e644b877d1100cb542dab1a2663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to bip-0037
Version messages above 70001 require a Relay Flag
By default is true, but you can change to false with setter.
https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki