Skip to content

Fix string serializer in python3. Expects bytes, not str. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
achow101 wants to merge 1 commit into from
Closed

Fix string serializer in python3. Expects bytes, not str. #163

achow101 wants to merge 1 commit into from

Conversation

@achow101
Copy link
Contributor

@achow101 achow101 commented Jan 1, 2018

The stream_serialize method for VarStringSerializer uses the write() function which expects bytes in python3, not str.

petertodd added a commit that referenced this pull request Apr 13, 2018
@petertodd
Minor: improve documentation
2fc846a 
Apparently caused some confusion: #163
@petertodd
Copy link
Owner

petertodd commented Apr 13, 2018

Sorry, that's meant to serialize byte strings, not textual strings.

I improved the docs instead: 2fc846a

@petertodd petertodd closed this Apr 13, 2018
rawBit-io pushed a commit to rawBit-io/python-bitcointx that referenced this pull request Nov 6, 2025
@petertodd
Minor: improve documentation
f8a3945 
Apparently caused some confusion: petertodd#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achow101 @petertodd