handle non-standard RPC responses #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes there is a need to issue RPC commands to the services that just pretend to be bitcoind, by emulating some of its commands. These services might not follow the same protocol for error reporting as bitcoind does. An example of such service would be feesim (https://github.com/bitcoinfees/feesim, Model-based Bitcoin fee estimation) With these changes, we can handle non-standard error responses gracefully.
petertodd
added a commit
that referenced
this pull request
Aug 21, 2019
cd81db6 handle non-standard RPC responses (Dmitry Petukhov) Pull request description: Sometimes there is a need to issue RPC commands to the services that just pretend to be bitcoind, and are emulating some of its commands. These services might not follow the same protocol for error reporting as bitcoind does. An example of such service would be feesim (https://github.com/bitcoinfees/feesim, Model-based Bitcoin fee estimation) With these changes, we can handle non-standard error responses gracefully. Top commit has no ACKs. Tree-SHA512: 7cadfeee8bb70b4815b5d19385186ad55dca8d1c7c1448d9d55b58563552cf3b6d2c0fe8723855ff1751a5b5c396e904e2aa368ad42bc08a17b6360197317e82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is a need to issue RPC commands to the services
that just pretend to be bitcoind, and are emulating some of its commands.
These services might not follow the same protocol for error reporting
as bitcoind does. An example of such service would be feesim
(https://github.com/bitcoinfees/feesim, Model-based Bitcoin fee estimation)
With these changes, we can handle non-standard error responses
gracefully.