CScript.is_witness_scriptpubkey : size must match second byte + 2 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model CScript.is_witness_scriptpubkey after bitcoind's CScript::IsWitnessProgram -- it not only checks for script size and first opcode, but also checks that data push size equals script size + 2 (entire script consists of version byte and data push). In absense of this check, is_witness_scriptpubkey wrongfully detects 1-of-1 p2sh redeem script as a witness program.
petertodd
added a commit
that referenced
this pull request
Aug 21, 2019
…byte + 2 629a919 CScript.is_witness_scriptpubkey : size must match second byte + 2 (Dmitry Petukhov) Pull request description: Model CScript.is_witness_scriptpubkey after bitcoind's CScript::IsWitnessProgram -- it not only checks for script size and first opcode, but also checks that data push size equals script size + 2 (entire script consists of version byte and data push). In absense of this check, is_witness_scriptpubkey wrongfully detects 1-of-1 p2sh redeem script as a witness program. Top commit has no ACKs. Tree-SHA512: 83a1ac530a107a0b69b549a81c1c9eb87152dd3c1f06a768f3c469ec3ae28c33d104d69d45aac23b48b76087f869ed1195989880fda5a34b1c78fad8a3504d64
Owner
|
Thanks! It'd be good to add a test for this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model CScript.is_witness_scriptpubkey after bitcoind's
CScript::IsWitnessProgram -- it not only checks for script size
and first opcode, but also checks that data push size equals
script size + 2 (entire script consists of version byte
and data push). In absense of this check, is_witness_scriptpubkey
wrongfully detects 1-of-1 p2sh redeem script as a witness program.