add comment on an argument of getblock rpc #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertodd
added a commit
that referenced
this pull request
Jan 2, 2019
18c883b add comment on an argument of getblock rpc (smasuda) Pull request description: I found this while I was looking around the code. "true/false" argument is no longer documented in bitcoin core's rpc, This comment might be helpful for those who look this in detail. We could change the argument to be 0 instead of false, however, it would break if someone is using bitcoin-core before v0.15.0. Tree-SHA512: b698fa059c42ebc894c2436622a6c1965d87000fefe505d01c37eba13ef0a746a215330772aa638c0757d9acc17a86d550314dd50a4e2a938e19c878ee2166f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while I was looking around the code. "true/false" argument is no longer documented in bitcoin core's rpc, This comment might be helpful for those who look this in detail.
We could change the argument to be 0 instead of false, however, it would break if someone is using bitcoin-core before v0.15.0.