Skip to content

add comment to __getattr__ in RawProxy to clarify the intent of check #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petertodd merged 1 commit into from
Aug 5, 2019
Merged

add comment to __getattr__ in RawProxy to clarify the intent of check #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bitcoin/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,10 @@ def __init__(self,

def __getattr__(self, name):
if name.startswith('__') and name.endswith('__'):
# Python internal stuff
# Prevent RPC calls for non-existing python internal attribute
# access. If someone tries to get an internal attribute
# of RawProxy instance, and the instance does not have this
# attribute, we do not want the bogus RPC call to happen.
raise AttributeError

# Create a callable to do the actual call
Expand Down