Fix python 27 incompatibility by defining FileNotFoundError #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems OK... I would prefer a subclass but this isn't so bad. Add a comment that this is py27-related, or wrap it in python version check magic. |
Contributor
Author
|
Yes sir, just added the comment and version check in 173e860 |
Owner
|
Python 2.7 is being depreciated soon; how important is this and how many need 2.7 support? |
Contributor
Author
|
That's why it's written in a way to be minimally invasive. I discovered the
issue while working on some gotenna related code that is imho not yet fully
ready for 3.x.
I submitted this small pull request b/c so far this repo lists 2.7 as
supported, but afaikr other tests do also fail already.
The proposed fix would be good to have but isn't crucial.
Peter Todd <notifications@github.com> schrieb am Sa., 13. Juli 2019, 10:30:
… Python 2.7 is being depreciated soon; how important is this and how many
need 2.7 support?
https://pythonclock.org/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#207?email_source=notifications&email_token=AAAUHWQFEFI5IWISGFYGHH3P7GHB5A5CNFSM4H6KBPOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3M3MI#issuecomment-511102385>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAUHWW5G6KY6QJ252EMJILP7GHB5ANCNFSM4H6KBPOA>
.
|
petertodd
added a commit
that referenced
this pull request
Aug 5, 2019
173e860 add version magic to python2 compat fix in rpc.py (Florian) 98ecbc6 work around a python 27 incompatibility by defining FileNotFoundError (Florian) Pull request description: This small pul requests fixes a compatibility with python27 by by defining FileNotFoundError. Tree-SHA512: c0e32a1be986f1bb4c4ebfa3b06d0e50f2e442f2b06f16b66e681838b39b69e562d5cee6019b2cfd606b42260efb1cf0ba6fe0b9d8f531f60e46dc512ce1b49d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small pul requests fixes a compatibility with python27 by by defining FileNotFoundError.