Remove attempted Python 2 compatibility #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hacky approach precludes Mypy type checking. Python 2 is not supported any more, and Tox is not running the test suite in this version either.
dgpv
reviewed
Oct 13, 2020
Contributor
|
I've read the diff, and the changes look good to me (except one small moment re |
Contributor
Author
|
@dgpv Thanks for the quick review. I have added another commit that renames and documents the hexlify/unhexlify wrappers. |
These wrapper work differently than functions from binascii, even though they have the same name. That could be a source of confusion. In this commit, the functions are renamed to make it clear that they operate with strings. Because they cannot handle Unicode in any meaningful way, I have changed their implementation to not even attempt it, as it is more complicated to handle Unicode, and it doesn't even work anyway.
Contributor
|
Just could be enough, IMO, as the code is very short and obvious. But more documentation is not less, so I'm not complaining. |
Contributor
Author
|
@petertodd Hi, any possibility of having you look at this? I'd be ready to make any necessary changes. |
Owner
|
I haven't actually tested this. But looks fine and I'm going to unilaterally pull the plug on Py2. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hacky approach precludes Mypy type checking.
Python 2 is not supported any more, and Tox is not running
the test suite in this version either.