bitcoin.rpc.RawProxy, 443 as default port for HTTPS and more robust parsing of bitcoin.conf#37
Merged
petertodd merged 2 commits intopetertodd:masterfrom Jan 4, 2015
gitmarek:rpctweaks
Merged
bitcoin.rpc.RawProxy, 443 as default port for HTTPS and more robust parsing of bitcoin.conf#37petertodd merged 2 commits intopetertodd:masterfrom gitmarek:rpctweaks
petertodd merged 2 commits intopetertodd:masterfrom
gitmarek:rpctweaks
Conversation
Owner
|
Checked the Bitcoin Core code - a empty rpcuser is OK but an empty rpcpassword is not. So lets change this pull-req to raise an exception if rpcpassword is empty, and allow rpcuser to be empty. (with a default of "") |
added 2 commits
January 3, 2015 13:51
Also remove unnecessary FIXME comment (fixed by 28518d2).
and raise an exception if rpcpassword is not specified.
Comment: You can make RPC calls to bitcoind when bitcoin.conf specifies
just rpcpassword and leaves user name empty. The class bitcoin.rpc.RawProxy
creates keys of the internal dictionary: conf = {}, based on the entries
in the configuration file. Then assumes that the rpcuser key exists and
uses it to create service_url. This results in an error
when bitcoin.conf contains only rcppassword field and the following code
is executed:
> proxy = bitcoin.rpc.RawProxy()
Contributor
Author
|
Followed your suggestions in ea73e3f. Also, changed order of the commits and rebased on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor changes to bitcoin.rpc.RawProxy:
Do not assume that bitcoin.conf file specifies rpcuser.
Use port 443 as default for https RPC connections.