Update importaddress rpc call to handle no label, rescan=False #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertodd
added a commit
that referenced
this pull request
May 23, 2015
9093b64 Update importaddress rpc call to handle no label, rescan=False (Michael Goldstein)
|
I can set the label to an empty string, but rescan seems to run regardless of whether I set it to True or False. |
Owner
|
@patrick7kelly What version of Bitcoin Core are you using? I just tried reproducing this on v0.11.x - git HEAD - and it seems to work as expected. Also, if you could reply with exactly what lines of code you used that'd be great. |
|
Using Bitcoin-core 0.10.2 It's worth noting that I don't have an issue when using |
ghtdak
pushed a commit
to ghtdak/python-bitcoinlib
that referenced
this pull request
Dec 1, 2015
9093b64 Update importaddress rpc call to handle no label, rescan=False (Michael Goldstein) [ yapified by gitreformat (github/ghtdak) on Mon Nov 30 21:12:13 2015 ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the importaddress RPC call requires having something in the label parameter in order to check the rescan parameter, I changed the default value of label to an empty string. The code now sends an RPC call with all of the parameters every time, such that all cases are handled properly.
Alternatively, the default value can remain None, but this would require if-else spaghetti.