Fixed a bug in bloom filter deserialization#98
Merged
petertodd merged 1 commit intopetertodd:masterfrom Nov 24, 2015
Merged
Conversation
petertodd
added a commit
that referenced
this pull request
Nov 24, 2015
41a88ee fixed bug in bloom filter deserialization (Antoine Le Calvez)
ghtdak
pushed a commit
to ghtdak/python-bitcoinlib
that referenced
this pull request
Dec 1, 2015
41a88ee fixed bug in bloom filter deserialization (Antoine Le Calvez) [ yapified by gitreformat (github/ghtdak) on Mon Nov 30 21:12:50 2015 ]
rawBit-io
pushed a commit
to rawBit-io/python-bitcointx
that referenced
this pull request
Nov 6, 2025
b277026 fixed bug in bloom filter deserialization (Antoine Le Calvez)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code was invalid and not tested (_ser_read is not declared in the scope and the name isn't even right), plus self was used in a classmethod before the 'self' variable declaration. Also removed another unused import.
It's now fixed and tested.