refactor: make codec layer fully header-only#23
Merged
petesramek merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com> Agent-Logs-Url: https://github.com/petesramek/tiny-link/sessions/822fb91b-cc43-4f24-8888-79646c3eda00
Co-authored-by: petesramek <2333452+petesramek@users.noreply.github.com> Agent-Logs-Url: https://github.com/petesramek/tiny-link/sessions/822fb91b-cc43-4f24-8888-79646c3eda00
Copilot created this pull request from a session on behalf of
petesramek
March 23, 2026 12:48
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three codec files (
Fletcher16,CobsCodec,Packet) were split into.h/.cpppairs while everything else — the mainTinyLinkengine, all platform adapters, and all protocol types — was header-only. This inconsistency required a separate compilation step for no real benefit.Changes
.cppbodies into headers — function definitions moved inline,.cppfiles deletedstatic inlinepreserved onpacket_size;inlineapplied to all other codec functionsPacket.hgains#include <string.h>and#include "Fletcher16.h"(previously pulled in transitively via the.cpp)With a single MCU translation unit this removes call overhead on the checksum and COBS hot paths, and the build no longer needs to compile or link separate codec objects.