Skip to content

chore(deps): Update bincode requirement from 1.3 to 2.0#9

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/cargo/bincode-2.0
Closed

chore(deps): Update bincode requirement from 1.3 to 2.0#9
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/cargo/bincode-2.0

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Nov 26, 2025

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Nov 26, 2025

Labels

The following labels could not be found: dependencies, rust. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot bot requested a review from petitan as a code owner November 26, 2025 21:36
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0 branch from 8f652e5 to c6d2d5f Compare November 28, 2025 18:19
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0 branch 3 times, most recently from efdd243 to b6e0974 Compare December 12, 2025 10:01
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0 branch 6 times, most recently from dbfb809 to 334d592 Compare December 20, 2025 07:21
petitan added a commit that referenced this pull request Dec 21, 2025
CRITICAL:
- BUG #1: Transaction commit/rollback now uses write lock (was read lock - race condition)
- BUG #2: max_operations=0 now uses default limit (was unlimited - DoS vulnerability)
- BUG #3: switch_database acquires write lock before existence check (TOCTOU fix)
- BUG #4: API key serialization uses ? instead of unwrap (was panic risk)

HIGH:
- BUG #5: Script versioning uses optimistic locking with version check (race condition fix)
- BUG #6: API key cache logs errors instead of silent ignore
- BUG #7: Script delete checks for dependent scripts before deletion
- BUG #8: TLS key file read once into memory, no double-open
- BUG #9: Collection flags update uses write lock (was read lock)

MEDIUM:
- BUG #10: Projection validation checks values before truncating cast
- BUG #12: Script name validation added (same rules as collection names)
- BUG #13: Directory creation failures logged instead of silent ignore
- BUG #14: All unwrap/expect calls replaced with proper error handling

NOT A BUG:
- BUG #11: parking_lot::Mutex doesn't poison (verified)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
petitan added a commit that referenced this pull request Dec 21, 2025
BUG #1: Signal handler panic - .expect() replaced with graceful error handling
BUG #2: Error response body read - unwrap_or_default() replaced with proper error handling
BUG #3: JSON serialization - .ok() replaced with serialize_response() helper
BUG #4: stdout write errors - detect broken pipe and exit gracefully
BUG #5: DoS via unbounded batch - add MAX_BATCH_SIZE limit (1000)
BUG #6: DoS via response size - add MAX_RESPONSE_SIZE limit (10MB)
BUG #7: SSRF via URL parsing - use url crate for proper URL construction
BUG #8: Insecure TLS mode - add prominent warning banner
BUG #9: Notification errors silent - log notification forward errors
BUG #10: Health check sleep overflow - cap backoff to MAX_HEALTH_BACKOFF_MS
BUG #11: Empty batch allowed - reject per JSON-RPC 2.0 spec
BUG #12: Missing jsonrpc validation - validate "2.0" version field

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0 branch 2 times, most recently from 29bdaaa to 7e68164 Compare December 25, 2025 21:56
---
updated-dependencies:
- dependency-name: bincode
  dependency-version: 2.0.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0 branch from 7e68164 to 4cdfe03 Compare December 25, 2025 22:28
petitan added a commit that referenced this pull request Dec 26, 2025
Security fixes:
- #7: API key timing attack - constant-time comparison now length-independent
- #9: _system.scripts access - restricted to localhost only
- #12: RwLock poison panic - graceful error handling instead of unwrap()
- #17: Collection name validation - blocked '.' to prevent fake system collections
- #19: Admin error enumeration - generic error message prevents info disclosure
- #4: Rhai privilege escalation - blocked _system.* writes from scripts
- #6: Schema silent failure - errors now logged instead of ignored
- #15-16: Error message info leak - sanitized storage/script error messages

All 66 tests passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jan 26, 2026

Superseded by #28.

@dependabot dependabot bot closed this Jan 26, 2026
@dependabot dependabot bot deleted the dependabot/cargo/bincode-2.0 branch January 26, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants