Skip to content

Conversation

@faisal-hameed
Copy link

This pull request is focused on resolving occurrences of Sonar rule
squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1213

Please let me know if you have any questions.

Faisal Hameed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.933% when pulling c0646d4 on DevFactory:release/members-declaration-order-fix-1 into 1be0347 on petitparser:master.

@renggli
Copy link
Member

renggli commented Jul 2, 2016

Thank you for the cleanup proposal.

In my opinion the automatic re-ordering reduces the readability of the code. I have carefully arranged the code so that common (static) constructors appear on top, before the less common normal instructor. Also I like to have static constants to be close to the method using them.

@renggli renggli closed this Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants