fix: add org baseline secret patterns to .gitignore#212
Conversation
Copies the petry-projects org secrets baseline verbatim into the repo, adding the required *.pem and *.key patterns (and many others) per the push-protection standard. Repo-specific entries (node_modules/, coverage/, test-results/, playwright-report/) are preserved in a dedicated section at the top. The standalone .env entry is removed since it's covered by the baseline's dotenv section. Closes #172 Co-authored-by: don-petry <don-petry@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Self-review complete — no issues found. Only @don-petry — this is ready for your review and merge. This resolves the recurring compliance finding in #172. |
|
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 5778a17776e1bc15905ada6637cdacc2e3720f48
Review mode: triage-approved (single reviewer)
Summary
A .gitignore-only change (+394 / -0) that copies the petry-projects org secrets baseline verbatim, satisfying the compliance finding in #172 (missing *.pem and *.key patterns). Repo-specific entries are preserved in a dedicated section at the top; the standalone .env entry is removed because it is now covered by the baseline's dotenv section.
Linked issue analysis
Issue #172 is a compliance-audit warning from the weekly audit: .gitignore is missing baseline secret patterns *.pem and *.key. The diff adds both patterns (section 4, SSH/TLS/GPG key material) along with the full org baseline. The remediation requested by the standard is satisfied verbatim.
Findings
No blocking issues. A few observations from a careful read:
- Repo-specific entries preserved.
node_modules/,coverage/,test-results/,playwright-report/remain at the top of the file, ahead of the baseline section. - Negation ordering is correct. Re-include rules (
!.env.example,!*.pub,!*.enc.yaml,!*.tfvars.example,!Pulumi.yaml, etc.) are placed immediately after the broad ignore patterns they carve out of, matching the ordering note in the baseline's preamble. .envconsolidation is intentional. The standalone.envline was removed because the new dotenv section covers.envand.env.*with explicit re-allows for.env.example/.sample/.template. No regression.*.pem/*.keyfalse-positive risk acknowledged. The baseline itself calls this out and recommends per-repo!overrides for specific fixture files. No action needed here since this repo doesn't currently track any*.pem/*.keyfiles.
CI status
All required checks green on the reviewed SHA:
- CodeQL — Analyze (actions): SUCCESS
- CodeQL — Analyze (javascript-typescript): SUCCESS
- CodeQL — Analyze (python): SUCCESS
- CodeQL (aggregate): SUCCESS
- CodeRabbit: SUCCESS (no actionable comments)
- SonarQube Cloud: Quality Gate passed (0 new issues, 0 hotspots)
Merge state is BLOCKED only because a review from petry-projects/org-leads is required; nothing in CI is failing.
Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.
|
Auto-rebase failed — merge conflict — this branch has conflicts with Please resolve the conflicts and push: |



Summary
petry-projectsorg secrets baseline verbatim into.gitignore, adding the required*.pemand*.keypatterns per the push-protection standardnode_modules/,coverage/,test-results/,playwright-report/) in a dedicated section at the top.enventry since it's already covered by the baseline's dotenv sectionCloses #172
Test plan
.gitignoreis changed — no code logic affected, no test failures expected*.pemand*.keypatterns are present in the updated fileGenerated with Claude Code
Summary by CodeRabbit