feat: add support for i18n#10
Merged
marcos-cereijo-pexip merged 5 commits intomasterfrom Aug 6, 2025
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR implements internationalization (i18n) support for the message overlay plugin, adding English and Dutch language support and updating the plugin API dependency to version 21.1.2.
- Added i18next library integration with HTTP backend for dynamic language loading
- Replaced all hardcoded strings with internationalized versions using translation keys
- Added language change event handler to update UI when language is switched
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Removed mkcert plugin and simplified configuration |
| src/index.ts | Added i18n import and language change event handler |
| src/i18n.ts | New i18n configuration with HTTP backend |
| src/forms/createSelectRoomForm.ts | Replaced hardcoded strings with i18n translations |
| src/forms/createInputMessageForm.ts | Replaced hardcoded strings with i18n translations |
| public/locales/nl/translation.json | Added Dutch translations |
| public/locales/en/translation.json | Added English translations |
| package.json | Updated dependencies including plugin-api and i18n libraries |
Collaborator
|
In webapp3 we have script which generates the core translation file for englisch. Could it make sense to have something here ase well ?
|
timwilking
reviewed
Aug 5, 2025
timwilking
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for i18n and english and dutch. It requires plugin-api 21.1.2.