chore: move the button from settings to the toolbar#14
Merged
marcos-cereijo-pexip merged 2 commits intomasterfrom Aug 7, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR moves a button from the settings menu to the toolbar while maintaining the same functionality. The change involves updating the button's position, replacing the text label with an icon and tooltip, and adjusting the TypeScript type annotation.
- Changed button position from 'settingsMenu' to 'toolbar'
- Replaced text label with SVG icon and tooltip
- Updated TypeScript type from
Button<'settingsMenu'>toButton<'toolbar'>
timwilking
reviewed
Aug 6, 2025
marcos-cereijo-pexip
force-pushed
the
13-move-the-button-from-settings-to-the-toolbar
branch
from
36123d4 to
eb3e089
Compare
timwilking
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the button from the
settingsPanelto thetoolbar, but with the same behavior.