Skip to content

feat: add support for breakout rooms#2

Merged
marcos-cereijo-pexip merged 8 commits intomasterfrom
feat/add-support-for-breakout-rooms
Sep 5, 2024
Merged

feat: add support for breakout rooms#2
marcos-cereijo-pexip merged 8 commits intomasterfrom
feat/add-support-for-breakout-rooms

Conversation

@marcos-cereijo-pexip
Copy link
Copy Markdown
Collaborator

Change also the message overlay in all the breakout rooms.

@marcos-cereijo-pexip marcos-cereijo-pexip self-assigned this Aug 26, 2024
@marcos-cereijo-pexip marcos-cereijo-pexip linked an issue Aug 26, 2024 that may be closed by this pull request
@marcos-cereijo-pexip marcos-cereijo-pexip marked this pull request as draft August 26, 2024 10:46
@marcos-cereijo-pexip marcos-cereijo-pexip marked this pull request as ready for review August 26, 2024 13:37
@marcos-cereijo-pexip marcos-cereijo-pexip marked this pull request as draft August 29, 2024 07:47
@marcos-cereijo-pexip
Copy link
Copy Markdown
Collaborator Author

Adding a selector to change between:

  • All rooms.
  • Main room.
  • Breakout room 1
  • Etc.

@marcos-cereijo-pexip marcos-cereijo-pexip force-pushed the feat/add-support-for-breakout-rooms branch from 997fba2 to e0cb13c Compare August 30, 2024 09:10
@marcos-cereijo-pexip marcos-cereijo-pexip marked this pull request as ready for review August 30, 2024 09:10
Copy link
Copy Markdown
Collaborator

@TsvetozarTsonev TsvetozarTsonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

A couple more comments:

  • you can get rid of the breakoutRooms.ts file and you can just hold them in the index file and pass them as a prop to handleSubmitMessage as they are only used there
  • for the plugin.ts, you can just export let plugin and assign it in the index, and avoid the getters and setters, usually its a good practice but its a bit of an overkill here (IMHO)

Comment thread src/index.ts
Comment thread src/index.ts
@marcos-cereijo-pexip
Copy link
Copy Markdown
Collaborator Author

Nice!

A couple more comments:

  • you can get rid of the breakoutRooms.ts file and you can just hold them in the index file and pass them as a prop to handleSubmitMessage as they are only used there
  • for the plugin.ts, you can just export let plugin and assign it in the index, and avoid the getters and setters, usually its a good practice but its a bit of an overkill here (IMHO)

@TsvetozarTsonev , I changed the part related to the breakoutRooms, but I cannot do the same with the plugin (or I don't know exactly how to do it). If I import the index.ts in another file, it's triggered twice.

@marcos-cereijo-pexip
Copy link
Copy Markdown
Collaborator Author

@TsvetozarTsonev I modified the code and now I export the plugin variable directly.

@marcos-cereijo-pexip marcos-cereijo-pexip merged commit ebbf581 into master Sep 5, 2024
@marcos-cereijo-pexip marcos-cereijo-pexip deleted the feat/add-support-for-breakout-rooms branch September 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for breakout rooms

2 participants