FreeBSD /bin/sh test workaround, simple "call and response" test using bc(1)#20
Merged
FreeBSD /bin/sh test workaround, simple "call and response" test using bc(1)#20
Conversation
There is something I am not able to understand about /bin/sh on freebsd: This is actually some kind of "second output of input echo" that occurs only with the AT&T-compatible /bin/sh on FreeBSD, and intermittently (a modified version of the test runs forever on OSX and Linux). Complete analysis is in issue #12, #12 (comment)
- We cannot use any of the setecho/getecho family of functions on solaris, skip them on such platform. - Do not unnecessary test the same in test_interactive_* family of tests, these are covered by test_echo.py - When the EOFError is caught, any *further* reads will **block** forever on Solaris, whereas Linux, FreeBSD, and OSX would continue to raise EOFError. No need to unnecessarily test such OS internal, remove such test.
As noted in in the methods for this, there are no workarounds for Solaris, we need to be careful not to use such methods, as they block forever, causing the test runner to freeze up.
I've only seen this happen once on Solaris, and I admit that I don't really understand it!
Closed
Contributor
Author
|
With these changes (to tests, only), I am confident in a ptyprocess v0.5, anyway. It will ensure "green" builds downstream for all OS's (except for the remaining asyncio/EOF issue in pexpect, I hope to return to this specific issue after a short break) |
Member
|
All looking good to me. Thanks! |
takluyver
added a commit
that referenced
this pull request
Apr 27, 2015
FreeBSD /bin/sh test workaround, simple "call and response" test using bc(1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
echo=False. I thoroughly tested the getecho/setecho/waitnoecho family of functions (and discovered PR bugfix: waitnoecho() refers to missing self.timeout #19 along the way). If I run "stty -echo" on bash, then bc, my input is most certainly not written to output._is_irixwaitnoechotests on Solaris