Add feature to return only non-expired entries#304
Merged
pfn merged 5 commits intopfn:masterfrom Mar 7, 2017
Merged
Conversation
pfn
reviewed
Mar 7, 2017
|
|
||
| Func<PwEntry, bool> hideExpired = delegate(PwEntry e) | ||
| { | ||
| DateTime dtNow = DateTime.UtcNow; |
Owner
|
looks good, just fix the minor space thing and I'll merge. Thanks for the PR |
Contributor
Author
|
I changed the one line that had tab indents to space indents. |
Owner
|
thank you |
Contributor
Author
|
Fixes #198 |
Contributor
Author
|
I just realized that when I removed the changed plgx file, it removed it completely. I imagine you'll recompile the file yourself, but right now, the file does not exist in the master branch. |
This was referenced Nov 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new feature lets the user return only entries that are current and valid. It excludes all entries that are expired (expiry date has happened).
It adds a checkbox to the General tab of KeePassHttp Options. I made sure that the checkboxes and other elements were pushed down by 23 pixels, keeping the padding consistent.
The date check is copied from KeePass's own source code, so it should be consistent with the main app's definition of an expired entry.
I also recompiled the plgx file to include the new feature. I tested it with both Firefox (PassIFox) and Chrome (chromeIPass) on Linux Mint 18. Edit I removed the plgx from the branch, as it looks like you don't want that included (per the other pull requests' comments).
I did not add a test.