Skip to content

fix: Adjust test report of error cases#2

Merged
hrk091 merged 2 commits intomainfrom
fix/adjust_test_report
Sep 21, 2024
Merged

fix: Adjust test report of error cases#2
hrk091 merged 2 commits intomainfrom
fix/adjust_test_report

Conversation

@hrk091
Copy link
Copy Markdown
Contributor

@hrk091 hrk091 commented Sep 21, 2024

Problem:

  • The test results of the MatchCondition failure cases is mis-leading. It shows NOT MATCH or SETUP ERROR but it is better to show SKIP and ERROR to enable to compare with expected result directly.
  • The error raised by MatchCondition is treated as FatalError, but it should be handled as normal error and suppress test fail by setting error as expected result.

To resolve these issues, I've introduced new testResult structs and used them for each error cases to make sure that it shows proper test results even for error cases.

@hrk091 hrk091 merged commit 8c1058c into main Sep 21, 2024
@hrk091 hrk091 deleted the fix/adjust_test_report branch September 21, 2024 07:24
hrk091 added a commit that referenced this pull request Sep 21, 2024
@hrk091 hrk091 mentioned this pull request Sep 21, 2024
hrk091 added a commit that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant