Skip to content

Remove bazel#1

Merged
superbrothers merged 2 commits into
masterfrom
remove-bazel
May 14, 2026
Merged

Remove bazel#1
superbrothers merged 2 commits into
masterfrom
remove-bazel

Conversation

@superbrothers
Copy link
Copy Markdown
Member

This PR removes Bazel from this repository.

I want to update dependencies, but Bazel is outdated, making it difficult to update them.

@superbrothers superbrothers requested a review from hrntknr May 13, 2026 09:04
containers:
- name: sciuro
image: sciuro:{STABLE_GIT_TAG}
image: docker.io/cloudflare/sciuro
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist, and we don't have write permissions.
It's likely to fail during the push step in the release GitHub Actions process.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it in the next PR.

name = "sciuro-clusterrolebinding",
kind = "clusterrolebinding",
substitutions = {
"kube-system": "$(namespace)",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewrite logic from kube-system→node-remediation has been removed.
Please either manually rewrite the manifest or add rewrite logic.

(The sciuro ServiceAccount is in the non-namespaced namespace, but the ClusterRoleBinding points to kube-system.)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also modify it to use the node-remediation namespace in the next PR.

@superbrothers superbrothers requested a review from hrntknr May 13, 2026 09:44
@superbrothers superbrothers merged commit 77b81c5 into master May 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants