fix(ExceptionT): Only check for translation within the exception

[arkener]

Reference: https://www.drupal.org/project/coder/issues/3123061

[pfrenssen]

Thanks for the quick fix!

[pfrenssen]

Here are results for a "before" and "after" check in my project which was affected by 3 false positives. The result is perfect now!

Before

$ ./vendor/bin/phpcs
........................................................S...  60 / 706 (8%)
............................................................ 120 / 706 (17%)
............................................................ 180 / 706 (25%)
............S.........................................W..... 240 / 706 (34%)
........................W......W............................ 300 / 706 (42%)
............................................................ 360 / 706 (51%)
............................................................ 420 / 706 (59%)
............................................................ 480 / 706 (68%)
............................................................ 540 / 706 (76%)
............................................................ 600 / 706 (85%)
..S........................................S................ 660 / 706 (93%)
..............................................               706 / 706 (100%)



FILE: /home/pieter/v/joinup-dev/web/modules/custom/joinup_federation/src/JoinupFederationStepPluginBase.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 93 | WARNING | Exceptions should not be translated
-----------------------------------------------------------------------------------------------------------


FILE: /home/pieter/v/joinup-dev/web/modules/custom/joinup_federation/src/Plugin/pipeline/Step/UserSelectionFilter.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 127 | WARNING | Exceptions should not be translated
---------------------------------------------------------------------------------------------------------------------


FILE: /home/pieter/v/joinup-dev/web/modules/custom/joinup_federation/src/Plugin/pipeline/Step/ManualUpload.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 76 | WARNING | Exceptions should not be translated
--------------------------------------------------------------------------------------------------------------

Time: 8.17 secs; Memory: 54MB

After

$ ./vendor/bin/phpcs
........................................................S...  60 / 706 (8%)
............................................................ 120 / 706 (17%)
............................................................ 180 / 706 (25%)
............S............................................... 240 / 706 (34%)
............................................................ 300 / 706 (42%)
............................................................ 360 / 706 (51%)
............................................................ 420 / 706 (59%)
............................................................ 480 / 706 (68%)
............................................................ 540 / 706 (76%)
............................................................ 600 / 706 (85%)
..S........................................S................ 660 / 706 (93%)
..............................................               706 / 706 (100%)


Time: 8.15 secs; Memory: 54MB

👍