Test fail improvements [2890239]#3
Conversation
Ensure collaborators and CI tools are all using the same dependencies for development and testing. For more info see: - https://getcomposer.org/doc/01-basic-usage.md - https://getcomposer.org/doc/02-libraries.md#lock-file
These PHP versions are end of life and not supported currently by Drupal 8. See Drupal system requirements: - https://www.drupal.org/docs/7/system-requirements/php
|
No we shouldn't commit the lock file otherwise we will not be alerted if something breaks. If we commit the lock file then we are oblivious to incompatibilities that arise with our own dependencies, but our users aren't, since the versions in the lock file do not propagate to our user's projects. If any incompatibility will arise then we will not know, but our users will still be affected. That is a bad idea. |
|
@pfrenssen after a few beers and a discussion at the pub I tend to agree with you. I agree it's wiser to let the tests surface incompatibilities as underlying libraries change, due to the way this all works. Perhaps Travis.ci should run the tests weekly, if no commits are merged to the base branch, and a status badge could be added somewhere. |
2 participants
Suggested Changes
Ensure our CI server, and other developers collaborating on the project, runs and tests on the same dependencies.
Note: This change will not have any effect on other projects that depend on this library.
For details on the effect of comitting the
composer.lockfile to version control, see the following documentation:composer.lockFile to Version ControlRelated Issues