Merged
Conversation
Member
jaredhendrickson13
commented
Jul 26, 2024
jaredhendrickson13
commented
- Fixes an issue where dependency requirements for the package could conflict with pages in the webConfigurator PHP variable redeclaration error when accessing Status>Monitoring graphs after installing pfsense-api v2 #522
- Fixes an issue where pagination was unintentionally applied before queries
- Fixes a performance flaw with loading Model objects that could cause memory limits to be exceed on large datasets
…oaded in Model::read_all() This fixes an issue where Model::read_all() would load all Model objects each time it loaded a single Model object. This should greatly improve performance for reading large numbers of objects and queries.
This ensures queries are only performed if the client provided query parameters. Queries are more resource intensive since we have to load all objects to perform the query, even if pagination is used. If only pagination is needed and no query parameters were given, we now delegate the job to read_all(), which allows only the paginated objects to be loaded.
plural deletes are a feature being added in v2.1.0, but commits were ported for patches that contained references to the feature. This commit removes those references for now.
jaredhendrickson13
force-pushed
the
next_patch
branch
from
3969dd2 to
9200b1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.