Skip to content

fix(GraphQL): only mark types as nonNull if they are unconditional #778 #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaredhendrickson13 merged 3 commits into from
Nov 13, 2025
Merged

fix(GraphQL): only mark types as nonNull if they are unconditional #778 #780

jaredhendrickson13 merged 3 commits into from
Nov 13, 2025

Conversation

@jaredhendrickson13
Copy link
Member

@jaredhendrickson13 jaredhendrickson13 commented Nov 13, 2025

Fixes

@jaredhendrickson13
fix(GraphQL): only mark types as nonNull if they are unconditional #778
511e8f2 
Fields that are conditionally required need to be nullable as they are only required if the fields conditions are met. Marking them as nonNull types will result in schema errors if the condition is not met for a specific object.
@jaredhendrickson13
test(GraphQL): ensure conditionally required fields can always be que…
7856ae9 
…ried #778
@jaredhendrickson13
style: run prettier on changed files
d5e28a3
@jaredhendrickson13 jaredhendrickson13 linked an issue Nov 13, 2025 that may be closed by this pull request
GraphQL Query results in Internal Server Error for Nullable Fields #778
Closed
@jaredhendrickson13 jaredhendrickson13 merged commit c1bb0ac into master Nov 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GraphQL Query results in Internal Server Error for Nullable Fields

2 participants

@jaredhendrickson13