Skip to content

[dns_resolver] Do not always add an empty domainoverrides item #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opoplawski merged 1 commit into from
Aug 16, 2025
Merged

[dns_resolver] Do not always add an empty domainoverrides item #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/187_dns_resolver_domainoverrides.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "pfsense_dns_resolver - do not always add an empty domainoverrides item. (https://github.com/pfsensible/core/issues/187)"
5 changes: 2 additions & 3 deletions plugins/modules/pfsense_dns_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@
domainoverrides:
description: Domains for which the resolver's standard DNS lookup should be overridden.
required: false
default: []
type: list
elements: dict
suboptions:
Expand Down Expand Up @@ -349,7 +348,7 @@
regovpnclients=dict(default=False, type='bool'),
custom_options=dict(default="", type='str'),
hosts=dict(default=[], type='list', elements='dict', options=DNS_RESOLVER_HOST_SPEC),
domainoverrides=dict(default=[], type='list', elements='dict', options=DNS_RESOLVER_DOMAIN_OVERRIDE_SPEC),
domainoverrides=dict(type='list', elements='dict', options=DNS_RESOLVER_DOMAIN_OVERRIDE_SPEC),
# Advanced Settings
hideidentity=dict(default=True, type='bool'),
hideversion=dict(default=True, type='bool'),
Expand Down Expand Up @@ -482,7 +481,7 @@ def _validate_params(self):
if not self.pfsense.is_ipv4_address(ipaddr):
self.module.fail_json(msg=f'ip, {ipaddr} is not a ipv4 address')

for domain in params["domainoverrides"]:
for domain in params.get("domainoverrides", []):
if not self.pfsense.is_ipv4_address(domain["ip"]):
self.module.fail_json(msg=f'ip, {domain["ip"]} is not a ipv4 address')

Expand Down