Fix/spoc 468/trivy image scan triage#109
Conversation
…e image Replaces mattn/go-sqlite3 (CGO) with modernc.org/sqlite (pure Go), enabling a fully static binary and distroless/static base image. This resolves all Trivy findings at source with no suppressions needed: - glibc CVEs x13: eliminated by switching base image from distroless/base-debian12 to distroless/static-debian12 (no libc6) - libssl3 CVE-2025-27587: same base image switch (no libssl3) - stdlib CVEs: resolved by goreleaser/goreleaser:latest which ships Go 1.26.2, fixing all remaining CVEs including CVE-2025-68121 (CRITICAL) Additional improvements: - .goreleaser.yaml: collapse to single CGO_ENABLED=0 build for all platforms; fixes latent bug where darwin/windows builds silently dropped the sqlite driver at runtime - release.yaml: replace goreleaser-cross with goreleaser (no C cross-compiler needed), pin docker/* actions to full commit SHAs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- go.mod: go directive 1.25.4 → 1.26.0 - Upgrade github.com/moby/buildkit v0.27.1 → v0.28.1 (CVE-2026-33747, CVE-2026-33748) - Upgrade go.opentelemetry.io/otel/sdk and exporters v1.38/1.41 → v1.43.0 (CVE-2026-39882, CVE-2026-39883) - Upgrade google.golang.org/grpc v1.79.1 → v1.80.0 (CVE-2026-33186) - Dockerfile: add explicit USER nonroot Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request modernizes the build and runtime infrastructure by pinning GitHub Actions to commit SHAs, consolidating GoReleaser build configurations with CGO disabled, upgrading the Go toolchain to 1.26.0, migrating from mattn/go-sqlite3 to modernc.org/sqlite, and changing the container base image to a static variant with explicit user configuration. Changes
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
There was a problem hiding this comment.
🧹 Nitpick comments (2)
Dockerfile (1)
46-46: Minor: CA certificates copy may be redundant.The
gcr.io/distroless/static-debian12image already includes/etc/ssl/certs/ca-certificates.crt. The explicit copy from the downloader stage (line 46) is harmless but potentially unnecessary. The explicitUSER nonrootdirective (line 52) is good for clarity even though the:nonroottag already sets it.Also applies to: 52-53
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile` at line 46, The Dockerfile currently copies CA certs from the downloader stage using the COPY instruction ("COPY --from=downloader /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt") which is redundant because the base image gcr.io/distroless/static-debian12 already contains that file; remove that COPY line to simplify the build, and you can keep the explicit "USER nonroot" directive for clarity even though the :nonroot tag sets it implicitly..github/workflows/release.yaml (1)
33-34: Pin the GoReleaser image to a specific version tag.Using
goreleaser/goreleaser:latestintroduces reproducibility and supply-chain risks—builds may behave differently over time as the image updates. Pin to a specific version tag (e.g.,goreleaser/goreleaser:v2.15.2) for consistency with the other pinned actions in this workflow.Example fix
- goreleaser/goreleaser:latest \ + goreleaser/goreleaser:v2.15.2 \🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yaml around lines 33 - 34, Replace the floating image tag "goreleaser/goreleaser:latest" with a specific released version (for example "goreleaser/goreleaser:v2.15.2") to ensure reproducible builds; locate the step that invokes the goreleaser image (the line containing goreleaser/goreleaser:latest and the subsequent release --clean) and update the image tag to a fixed version that matches your pinned actions policy.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yaml:
- Around line 33-34: Replace the floating image tag
"goreleaser/goreleaser:latest" with a specific released version (for example
"goreleaser/goreleaser:v2.15.2") to ensure reproducible builds; locate the step
that invokes the goreleaser image (the line containing
goreleaser/goreleaser:latest and the subsequent release --clean) and update the
image tag to a fixed version that matches your pinned actions policy.
In `@Dockerfile`:
- Line 46: The Dockerfile currently copies CA certs from the downloader stage
using the COPY instruction ("COPY --from=downloader
/etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt") which is
redundant because the base image gcr.io/distroless/static-debian12 already
contains that file; remove that COPY line to simplify the build, and you can
keep the explicit "USER nonroot" directive for clarity even though the :nonroot
tag sets it implicitly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1be7b314-6a59-44aa-9d58-d036667d49b9
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (5)
.github/workflows/release.yaml.goreleaser.yamlDockerfilego.modpkg/taskstore/taskstore.go
- Remove redundant CA certs COPY from Dockerfile; distroless/static-debian12 already includes /etc/ssl/certs/ca-certificates.crt - Pin goreleaser image to v2.15.2 instead of :latest for reproducibility Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
No description provided.