Skip to content

chore: dev-env and e2e improvements#331

Merged
jason-lynch merged 1 commit intomainfrom
chore/dev-env-e2e-config
Apr 6, 2026
Merged

chore: dev-env and e2e improvements#331
jason-lynch merged 1 commit intomainfrom
chore/dev-env-e2e-config

Conversation

@jason-lynch
Copy link
Copy Markdown
Member

Summary

Makes a few small improvements to dev-env.zsh and the E2E configuration:

  • _choose-scope now highlights database by default because its the most common usage.
  • E2E_PARALLEL now defaults to 4 because this is a good setting for all fixtures.
  • The use-* functions now set E2E_FIXTURE. This makes it so that instead of setting E2E_FIXTURE explicitly, you can do:
use-lima
make test-e2e

or

use-dev-lima
make test-e2e

Makes a few small improvements to `dev-env.zsh` and the E2E
configuration:

- `_choose-scope` now highlights `database` by default because its the
  most common usage.
- `E2E_PARALLEL` now defaults to 4 because this is a good setting for
  all fixtures.
- The `use-*` functions now set `E2E_FIXTURE`. This makes it so that
  instead of setting `E2E_FIXTURE` explicitly, you can do:

```sh
use-lima
make test-e2e
```

or

```sh
use-dev-lima
make test-e2e
```
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

Reduces default E2E test concurrency from 8 to 4 via the Makefile. Updates the development environment script to manage E2E_FIXTURE exports across different runtime configurations (compose, dev-lima, lima, ec2) and reorders scope selection.

Changes

Cohort / File(s) Summary
Build Configuration
Makefile
Reduced default E2E_PARALLEL from 8 to 4, lowering concurrency for e2e test execution.
Development Environment
hack/dev-env.zsh
Reordered scope selection from host,database to database,host; added explicit E2E_FIXTURE management across runtime functions (unset in use-compose(), set to fixture name in use-dev-lima(), use-lima(), use-ec2()).

Poem

🐰 The rabbit hops through configs with care,
Parallel tests now gentler, more fair,
Fixtures declared from database to host,
Each environment knows what it needs most! ✨

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required sections: Testing (no test commands listed) and Checklist (not completed), though Summary and Changes are present. Add Testing section with test commands and complete the Checklist section to indicate which items apply to these changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic, using the broad term 'improvements' without specifying which improvements, making it unclear what the main change is. Consider a more specific title like 'chore: reduce default E2E parallelism and auto-configure fixtures' or 'chore: improve e2e defaults and dev-env fixture setup'.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/dev-env-e2e-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
hack/dev-env.zsh (1)

246-276: ⚠️ Potential issue | 🟡 Minor

Remove E2E_FIXTURE=dev-lima export from the use-dev-lima() function.

The dev-lima environment is for local interactive development using localhost-based lima instances, not for E2E fixture testing. There is no dev-lima.yaml in e2e/fixtures/vars/ and no deploy-dev-lima-fixture command to generate e2e/fixtures/outputs/dev-lima.test_config.yaml. Setting E2E_FIXTURE=dev-lima is misleading and will fail if someone attempts use-dev-lima && make test-e2e.

Follow the pattern of use-compose(), which correctly does unset E2E_FIXTURE for local development environments. Only use-lima() and use-ec2() should export E2E_FIXTURE, as they correspond to actual deployable fixtures.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@hack/dev-env.zsh` around lines 246 - 276, Remove the misleading E2E fixture
export inside the use-dev-lima() function: do not export E2E_FIXTURE=dev-lima
(unset or leave it unset like use-compose() does) because dev-lima is a local
interactive environment, not an e2e fixture; update use-dev-lima() to only set
CP_ENV=dev-lima and the SSH aliases (remove the E2E_FIXTURE export) so
use-lima() and use-ec2() remain the only functions that export E2E_FIXTURE.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@hack/dev-env.zsh`:
- Around line 246-276: Remove the misleading E2E fixture export inside the
use-dev-lima() function: do not export E2E_FIXTURE=dev-lima (unset or leave it
unset like use-compose() does) because dev-lima is a local interactive
environment, not an e2e fixture; update use-dev-lima() to only set
CP_ENV=dev-lima and the SSH aliases (remove the E2E_FIXTURE export) so
use-lima() and use-ec2() remain the only functions that export E2E_FIXTURE.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9abcd73-c100-4ef1-8c8a-85d030faf8a1

📥 Commits

Reviewing files that changed from the base of the PR and between 0724783 and 1a5b51f.

📒 Files selected for processing (2)
  • Makefile
  • hack/dev-env.zsh

@jason-lynch jason-lynch merged commit 873758c into main Apr 6, 2026
3 checks passed
@jason-lynch jason-lynch deleted the chore/dev-env-e2e-config branch April 6, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants